minor: remove unused endpointRegistry field from healthyEndpoints and…

… fadeIn (#3248) Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
zalando · Sep 25, 2024 · 2e9e3cf · 2e9e3cf
1 parent 1db1ac7
commit 2e9e3cf
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/proxy/fadein.go b/proxy/fadein.go
@@ -9,8 +9,7 @@ import (
 )
 
 type fadeIn struct {
-	rnd              *rand.Rand
-	endpointRegistry *routing.EndpointRegistry
+	rnd *rand.Rand
 }
 
 func (f *fadeIn) fadeInScore(lifetime time.Duration, duration time.Duration, exponent float64) float64 {

diff --git a/proxy/fadein_internal_test.go b/proxy/fadein_internal_test.go
@@ -92,7 +92,7 @@ func initializeEndpoints(endpointAges []float64, algorithmName string, fadeInDur
 		registry.GetMetrics(eps[i]).SetDetected(detectionTimes[i])
 	}
 
-	proxy := &Proxy{registry: registry, fadein: &fadeIn{rnd: rand.New(loadbalancer.NewLockedSource()), endpointRegistry: registry}, quit: make(chan struct{})}
+	proxy := &Proxy{registry: registry, fadein: &fadeIn{rnd: rand.New(loadbalancer.NewLockedSource())}, quit: make(chan struct{})}
 	return route, proxy, eps
 }
 

diff --git a/proxy/healthy_endpoints.go b/proxy/healthy_endpoints.go
@@ -9,7 +9,6 @@ import (
 
 type healthyEndpoints struct {
 	rnd                        *rand.Rand
-	endpointRegistry           *routing.EndpointRegistry
 	maxUnhealthyEndpointsRatio float64
 }
 

diff --git a/proxy/proxy.go b/proxy/proxy.go
@@ -841,16 +841,14 @@ func WithParams(p Params) *Proxy {
 	if p.EnablePassiveHealthCheck {
 		healthyEndpointsChooser = &healthyEndpoints{
 			rnd:                        rand.New(loadbalancer.NewLockedSource()),
-			endpointRegistry:           p.EndpointRegistry,
 			maxUnhealthyEndpointsRatio: p.PassiveHealthCheck.MaxUnhealthyEndpointsRatio,
 		}
 	}
 	return &Proxy{
 		routing:  p.Routing,
 		registry: p.EndpointRegistry,
 		fadein: &fadeIn{
-			rnd:              rand.New(loadbalancer.NewLockedSource()),
-			endpointRegistry: p.EndpointRegistry,
+			rnd: rand.New(loadbalancer.NewLockedSource()),
 		},
 		heathlyEndpoints:         healthyEndpointsChooser,
 		roundTripper:             p.CustomHttpRoundTripperWrap(tr),