Skip to content

Commit

Permalink
hithub: disable testcontainers Ryuk
Browse files Browse the repository at this point in the history
Disable reaper container for github builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
  • Loading branch information
AlexanderYastrebov committed Feb 12, 2024
1 parent 3c3f0c1 commit 6c6e481
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/master.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: master

permissions: {}

on:
push:
branches:
- master
permissions: {}
env:
TESTCONTAINERS_RYUK_DISABLED: true
jobs:
tests:
runs-on: ubuntu-latest
Expand All @@ -16,7 +16,7 @@ jobs:
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
with:
# https://www.npmjs.com/package/semver#caret-ranges-123-025-004
go-version: '^1.21'
go-version: "^1.21"
check-latest: true
- run: go version
- run: make deps
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: pr
on: [ pull_request ]
permissions:
contents: read
env:
TESTCONTAINERS_RYUK_DISABLED: true
jobs:
semgrep:
if: ${{ github.actor != 'dependabot[bot]' }}
Expand All @@ -23,7 +25,7 @@ jobs:
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
with:
# https://www.npmjs.com/package/semver#caret-ranges-123-025-004
go-version: '^1.21'
go-version: "^1.21"
check-latest: true
- run: go version
- run: make deps
Expand All @@ -35,7 +37,7 @@ jobs:
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491
with:
# https://www.npmjs.com/package/semver#caret-ranges-123-025-004
go-version: '^1.21'
go-version: "^1.21"
check-latest: true
- run: go version
- run: make deps
Expand Down

0 comments on commit 6c6e481

Please sign in to comment.