Make min-drop-probability of PHC optional #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanZavodskikh
force-pushed
the
phc/minDropProbabilityNonDefault
branch
from
132bdd8 to
464a07c
Compare
The default value (0.0) makes some sense and is equivalent to how PHC was working before. Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
force-pushed
the
phc/minDropProbabilityNonDefault
branch
from
464a07c to
d693900
Compare
|
👍 |
1 similar comment
|
👍 |
| @@ -21,6 +21,7 @@ import ( | |||
| "time" | |||
| "unicode/utf8" | |||
|
|
|||
| "golang.org/x/exp/maps" | |||
There was a problem hiding this comment.
This is now in stdlib, see https://pkg.go.dev/maps
There was a problem hiding this comment.
Yes, but there is no maps.Keys method on the stdlib page.
https://pkg.go.dev/maps
The experimental for comparison.
https://pkg.go.dev/golang.org/x/exp/maps
There was a problem hiding this comment.
Right, indeed golang/go#61538. Thanks for checking
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
May 7, 2024
[Changes](zalando/skipper@v0.21.76...v0.21.86) * zalando/skipper#3067 * zalando/skipper#3066 * zalando/skipper#3060 * zalando/skipper#3061 * zalando/skipper#3062 * zalando/skipper#3063 * zalando/skipper#3064 * zalando/skipper#3057 * zalando/skipper#3055 * zalando/skipper#3053 See closed #7450 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
The default value (0.0) makes some sense and is equivalent to how PHC was working before. Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de> Co-authored-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value (0.0) makes some sense and is equivalent to how PHC was working before.