Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPA filters: Reduce default buffer size for reading the requests' body #3257

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

mjungsbluth
Copy link
Collaborator

This PR

  • reduces the default buffer size for reading the request body to 8KB
  • and makes it configurable via command line and Skipper config

…y and expose it via command line and config

Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de>
config/config.go Outdated Show resolved Hide resolved
@AlexanderYastrebov AlexanderYastrebov added the major moderate risk, for example new API, small filter changes that have no risk like refactoring or logs label Oct 1, 2024
config/config.go Outdated Show resolved Hide resolved
Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de>
@AlexanderYastrebov
Copy link
Member

👍

1 similar comment
@szuecs
Copy link
Member

szuecs commented Oct 7, 2024

👍

@szuecs szuecs merged commit 3d9c020 into master Oct 7, 2024
14 checks passed
@szuecs szuecs deleted the opa_body_read_buffer_reduction branch October 7, 2024 11:32
RomanZavodskikh pushed a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Oct 8, 2024
Pushpalanka pushed a commit that referenced this pull request Oct 11, 2024
#3257)

* OPA filters: Reduce default buffer size for reading the requests' body and expose it via command line and config

Signed-off-by: Magnus Jungsbluth <magnus.jungsbluth@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major moderate risk, for example new API, small filter changes that have no risk like refactoring or logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants