API usage monitoring filter improvements #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-tschumak
force-pushed
the
949-api-usage-monitoring-filter-improvements
branch
from
ff95655 to
12d8135
Compare
…hs (instead of <unknown>) (zalando#949) Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
…lid config (zalando#949) Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
…alando#949) Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak
force-pushed
the
949-api-usage-monitoring-filter-improvements
branch
from
12d8135 to
a5442b7
Compare
…t pattern on filter level (incompatible interface change) (zalando#949) Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak
force-pushed
the
949-api-usage-monitoring-filter-improvements
branch
from
a5442b7 to
eb5ea86
Compare
tkrop
reviewed
Feb 11, 2019
maxim-tschumak
force-pushed
the
949-api-usage-monitoring-filter-improvements
branch
2 times, most recently
from
cc7cc67 to
f5517f6
Compare
…alando#949) Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak
force-pushed
the
949-api-usage-monitoring-filter-improvements
branch
from
f5517f6 to
df0657e
Compare
…ando#949) Signed-off-by: Maxim Tschumak <maxim.tschumak@gmail.com>
maxim-tschumak
force-pushed
the
949-api-usage-monitoring-filter-improvements
branch
from
0eb18b9 to
d3c7c48
Compare
|
👍 |
tkrop
approved these changes
Feb 13, 2019
aryszka
reviewed
Feb 13, 2019
aryszka
reviewed
Feb 13, 2019
| o.ApiUsageMonitoringRealmKey, | ||
| o.ApiUsageMonitoringClientIdKeyName, | ||
| o.ApiUsageMonitoringDefaultClientTrackingPattern, | ||
| o.ApiUsageMonitoringRealmKeys, |
There was a problem hiding this comment.
on the long term we should try to avoid compatibility breaking changes, but I see how this change makes this feature more usable 👍
There was a problem hiding this comment.
Agree! (that's why we haven't officially released the api-usage-monitoring filter within Z)
|
👍 |
|
Thanks for the PR! |
This was referenced Feb 14, 2019
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jun 6, 2024
* `-lb-healthcheck-interval` (zalando/skipper#2906) * `-api-usage-monitoring-default-client-tracking-pattern` (zalando/skipper#950 and zalando/skipper#1029) Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #949