Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WAL-E/WAL-G with custom PGPORT #582

Merged
merged 1 commit into from
May 14, 2021

Conversation

KarlHerler
Copy link
Contributor

Fixes issue #571.

The comment: #571 (comment) was not sufficient as PGPORT must also be placed in write_envidir_names or as implemented here.

Note that the current implementation adds the PGPORT file to the WAL-E/WAL-G configuration files indiscriminately, even if it isn't necessary for default port use cases. This does not cause any problems but it is redundant.

@sdudoladov
Copy link
Member

👍

1 similar comment
@CyberDem0n
Copy link
Contributor

👍

@CyberDem0n CyberDem0n merged commit baf6790 into zalando:master May 14, 2021
@CyberDem0n
Copy link
Contributor

Merged, thank you @KarlHerler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants