Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add metadata license to resource base #110

Closed
mwallschlaeger opened this issue Jun 14, 2024 · 3 comments · Fixed by #125
Closed

Feature: add metadata license to resource base #110

mwallschlaeger opened this issue Jun 14, 2024 · 3 comments · Fixed by #125
Assignees
Labels
admin changes to the admin interface API changes to rest API feature Forms changes to metadata forms Metadata transalation translations UI changes to the geonode UI

Comments

@mwallschlaeger
Copy link

mwallschlaeger commented Jun 14, 2024

Feature Description

add a field to the geonode.base.models.ResourceBase that holds the metadata_license. This should be linked to a table metadata_licenses. This table for now must only include a single lincense: CC-0. THe metadata_license can be designed like the original license table.

Make sure that:

  • new table metadata_license: exists
  • add a field to the form so that it can be used via the UI
  • the geonode.base.fixtures.initial_data.json fills this table with CC-0 and corresponding link to the latest version of it
  • make sure CC-0 is set as default when uploading a new dataset
  • configure serializer for api integration, also make sure that CC-0 is picked as defauklt when creating a dataset via the api
  • add admin interface for the metadata_license table which allows adding more metadata_licenses later on
  • give translations for the new field (@specka how we deal with translations at this phase of the implementation?)

Part of epic #9

@mwallschlaeger mwallschlaeger added feature UI changes to the geonode UI API changes to rest API Forms changes to metadata forms admin changes to the admin interface transalation translations Metadata labels Jun 14, 2024
@silvadealmeida silvadealmeida self-assigned this Jun 14, 2024
mwallschlaeger added a commit that referenced this issue Jun 25, 2024
…_license_to_resource_base

[Fixes #110] Feature: add metadata license to resource base
@specka specka assigned specka and unassigned mwallschlaeger Jun 27, 2024
@specka
Copy link

specka commented Jul 11, 2024

Übersicht meiner Tests:

  • ✔ : ich habe einen Datensatz hochgeladen und dort im Advanced Metadateneditor das Feld "Metadata License" gefunden
    Image
  • ❌ : ich habe im Django Admin die neue Datenbanktabelle "metadata_license gesucht und nicht gefunden. Der Test ist damit nicht erfolgreich.
    Image
  • ❌ : ich habe geprüft, ob CC0 standardmäßig beim erstellen eines neuen Datensatzes gesetzt ist; bei meinem Testdatensatz (hochgeladen über UI) war das nicht der Fall. Der Test ist damit nicht erfolgreich
  • ❌ : ich finde das Feld nicht beim Anschauen der Metadaten (metadata_detail);
  • 🔷 : ich konnte nicht prüfen, ob beim Hochladen per API dann das Feld CC0 automatisch gesetzt ist, da ich bei der API als Admin fungiere

(@mwallschlaeger Hier wäre es gut, wenn ich die API auch als specka@zalf.de nutzen könnte; welche schlüssel muss ich dafür dann im geonodectl angeben? Wo finde ich den?)

@specka
Copy link

specka commented Jul 11, 2024

@mwallschlaeger I reopened the issue because some of my tests "failed". Please check.

@specka specka reopened this Jul 11, 2024
@mwallschlaeger
Copy link
Author

please review #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin changes to the admin interface API changes to rest API feature Forms changes to metadata forms Metadata transalation translations UI changes to the geonode UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants