Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actionCreators config option passed to __REDUX_DEVTOOLS_EXTENSION__.connect() #526

Closed
brian-gavin opened this issue Jun 27, 2018 · 0 comments

Comments

@brian-gavin
Copy link
Contributor

In implementing the functionality for a redux-like framework, passing an actionsCreators object similar to

actionCreators = { action1: action1Builder, action2: action2Builder };
window.__REDUX_DEVTOOLS_EXTENSION__.connect({actionCreators});

I would assume that his would list the action creators (action1 and action2 respectively) in the dispatcher as mentioned in the documentation here

But diving into the code for the api it looks like this isn't implemented.

Is this due to gross misuse or is this feature not implemented?

brian-gavin pushed a commit to brian-gavin/redux-devtools-extension that referenced this issue Jul 3, 2018
Add actionCreators option handling to
__DEV_TOOLS_EXTENSION__.connect([options])

Fixes zalmoxisus#526
jhen0409 pushed a commit that referenced this issue Jul 4, 2018
Add actionCreators option handling to
__DEV_TOOLS_EXTENSION__.connect([options])

Fixes #526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant