Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for new Chrome limit on message size #582

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Conversation

zalmoxisus
Copy link
Owner

As discussed in #566 and #543, Chrome added a limit on messages, so we're splitting bigger object parts into chunks. However by increasing the sate, the extension will have out-of-memory crash at some point, so in future versions we need an option to run devtools from the client part, not from devpanel or extension window.

Here we're splitting messages only from content script to the background script. There is no need to do that also from background script to devpanel after #580 is merged.

@zalmoxisus
Copy link
Owner Author

Looks like the limit is for 64 MB. To check it, add 'a'.repeat(64 * 1024 * 1024) to redux state. We'd need a test for it running from Chrome.

We'd need this also for some parts where we're sending the state back. For non-redux apps we're including the state history for importing and the state from jumped point for time travelling. For redux apps we are sending just list of actions to recompute and jumped index. Not implementing that here as we want to avoid this workaround at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant