Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print button #22

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Print button #22

merged 1 commit into from
Oct 13, 2016

Conversation

zalmoxisus
Copy link
Owner

@zalmoxisus zalmoxisus commented Oct 12, 2016

This allows to print the graph view of the state or the history:
o98dry40pj

It seems there's no way to print the scaled svg chart, it will be cropped as we don't know the final size, so I'm resizing it back while printing (as seen in the demo above).

@zalmoxisus zalmoxisus merged commit 937a91a into master Oct 13, 2016
zalmoxisus added a commit to zalmoxisus/redux-devtools-extension that referenced this pull request Oct 13, 2016
@zalmoxisus
Copy link
Owner Author

zalmoxisus commented Oct 14, 2016

@jhen0409, seems like Electron cannot print from devpanel. Even though window.print() shows the system's print preview dialog, it has no effect. In Chrome it also doesn't work as expected when it's from devpanel (hangs the browser under some circumstances). So, I didn't include this button on devpanel, only when opening the extension's window.

On the other side, when calling window.print() from Electron's window it works as expected So, you can use it in react-native-debugger without problems, just make sure to adapt the css as in https://github.com/zalmoxisus/remotedev-app/blob/master/src/views/index.jade#L28-L48.

It's up in remotedev-app@0.8.0-beta-10.

jhen0409 pushed a commit to jhen0409/remotedev-app that referenced this pull request Oct 20, 2016
@zalmoxisus zalmoxisus deleted the print branch November 5, 2016 11:14
HadesHappy added a commit to HadesHappy/redux-devtools-extension that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant