Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up 128-bit fft using faster sum, mul, and using more lanes with avx512 #28

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

sarah-quinones
Copy link

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 21, 2024
src/fft128/f128_ops.rs Show resolved Hide resolved
src/fft128/mod.rs Show resolved Hide resolved
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge ! Do you want to prepare a patch release with this improvement or should we wait for the next work you want to do on f128 ?

@sarah-quinones
Copy link
Author

i think we can do a release for now. the recursive impl stuff is gonna take a bit of time to finish and it's backward compatible so we don't need to worry about a minor version bump

@IceTDrinker
Copy link
Member

ok maybe push a commit to bump the version then @sarah-ek ?

@sarah-quinones
Copy link
Author

done!

@IceTDrinker
Copy link
Member

done!

Thanks a lot, we'll wait for the CI and then we can publish the release, we'll update the concrete-fft version in TFHE-rs to benefit from the speed up :)

@sarah-quinones sarah-quinones merged commit fbe3d6c into main Feb 28, 2024
14 checks passed
@sarah-quinones sarah-quinones deleted the cheap_sum branch February 28, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants