Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Concrete Python to 2.7.0 #739

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

RomanBredehoft
Copy link
Collaborator

No description provided.

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner June 20, 2024 11:46
@cla-bot cla-bot bot added the cla-signed label Jun 20, 2024
pyproject.toml Outdated
@@ -34,7 +34,7 @@ readme = "README.md"
# Investigate if it is better to fix specific versions or use lower and upper bounds
# FIXME: https://github.com/zama-ai/concrete-ml-internal/issues/2665
python = ">=3.8.1,<3.11"
concrete-python = {version="==2.8.0rc1", source = "zama-pypi-cpu"}
concrete-python = {version="==2.7.0", source = "zama-pypi-cpu"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you change that, @RomanBredehoft (to public pypi?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I read poetry's doc and I think you're right, I therefore added a comment

@RomanBredehoft RomanBredehoft force-pushed the chore/update_cp_2_7_0 branch from 4a62bdb to 495c180 Compare June 20, 2024 12:11
Copy link

Coverage passed ✅

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    7885      0   100%

60 files skipped due to complete coverage.

@andrei-stoian-zama andrei-stoian-zama self-requested a review June 20, 2024 14:16
@RomanBredehoft RomanBredehoft merged commit 354d078 into main Jun 20, 2024
14 checks passed
@RomanBredehoft RomanBredehoft deleted the chore/update_cp_2_7_0 branch June 20, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants