Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ci2 #1110

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Refactor ci2 #1110

merged 4 commits into from
Nov 12, 2024

Conversation

BourgerieQuentin
Copy link
Member

workerB

@cla-bot cla-bot bot added the cla-signed label Oct 22, 2024
@BourgerieQuentin BourgerieQuentin force-pushed the refactor-ci2 branch 14 times, most recently from fb50e8d to 95c985b Compare October 25, 2024 09:52
@BourgerieQuentin BourgerieQuentin force-pushed the refactor-ci2 branch 14 times, most recently from acbb325 to 56866ca Compare November 6, 2024 13:13
github-actions[bot]
github-actions bot reviewed Nov 6, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 5d95e7b Previous: 4bdd1e0 Ratio
v0 PBS table generation 61122156 ns/iter (± 944988) 60953010 ns/iter (± 4636803) 1.00
v0 PBS simulate dag table generation 39744577 ns/iter (± 401435) 39440518 ns/iter (± 725300) 1.01
v0 WoP-PBS table generation 53977329 ns/iter (± 1412165) 52976464 ns/iter (± 1378247) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@BourgerieQuentin BourgerieQuentin force-pushed the refactor-ci2 branch 10 times, most recently from aa7b34a to d8dc7f6 Compare November 7, 2024 10:28
youben11
youben11 reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not easy to catch everything, so I did what I could, better to have more eyes on this.

.github/workflows/concrete_compiler_publish_docker_images.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
frontends/concrete-python/Makefile Outdated Show resolved Hide resolved
.github/workflows/concrete_compiler_publish_docker_images.yml Outdated Show resolved Hide resolved
soonum
soonum requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this huge refactoring !
Pretty much ready to go to production 👍

.github/workflows/commit_compliance.yml Outdated Show resolved Hide resolved
.github/workflows/commit_compliance.yml Outdated Show resolved Hide resolved
.github/workflows/commit_compliance.yml Show resolved Hide resolved
.github/workflows/concrete_compiler_benchmark.yml Show resolved Hide resolved
.github/workflows/concrete_compiler_benchmark.yml Show resolved Hide resolved
.github/workflows/docker_compliance.yml Show resolved Hide resolved
.github/workflows/scripts/teardown-check.sh Outdated Show resolved Hide resolved
ci/slab.toml Show resolved Hide resolved
ci/slab.toml Show resolved Hide resolved
ci/slab.toml Outdated Show resolved Hide resolved
@BourgerieQuentin BourgerieQuentin force-pushed the refactor-ci2 branch 4 times, most recently from 91a91b7 to b787e83 Compare November 8, 2024 14:25
soonum
soonum reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things to fix.

.github/workflows/concrete_compiler_benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/concrete_compiler_benchmark.yml Outdated Show resolved Hide resolved
.github/workflows/concrete_compiler_test_cpu.yml Show resolved Hide resolved
.github/workflows/concrete_python_finalize_release.yml Outdated Show resolved Hide resolved
.github/workflows/concrete_python_release_gpu.yml Show resolved Hide resolved
soonum
soonum approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it goes. Next step, fixing all actionlint warnings.

@BourgerieQuentin BourgerieQuentin merged commit 81af82f into main Nov 12, 2024
27 of 28 checks passed
@BourgerieQuentin BourgerieQuentin deleted the refactor-ci2 branch November 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@youben11 youben11 youben11 left review comments

@soonum soonum soonum approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BourgerieQuentin @youben11 @soonum