Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search space restriction #1125

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Search space restriction #1125

merged 1 commit into from
Nov 15, 2024

Conversation

aPere3
Copy link
Collaborator

@aPere3 aPere3 commented Oct 28, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 28, 2024
@aPere3 aPere3 requested a review from rudy-6-4 October 28, 2024 13:18
Copy link
Contributor

@rudy-6-4 rudy-6-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see with real implem.

@aPere3 aPere3 force-pushed the alex/optimizer_tfhers branch from 6db7910 to 266da78 Compare October 31, 2024 15:54
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: f70a18b Previous: 09894b6 Ratio
v0 PBS table generation 53763602 ns/iter (± 521216) 53863508 ns/iter (± 965902) 1.00
v0 PBS simulate dag table generation 38420347 ns/iter (± 525977) 38423465 ns/iter (± 390678) 1.00
v0 WoP-PBS table generation 52198086 ns/iter (± 282530) 52551878 ns/iter (± 494024) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@aPere3 aPere3 force-pushed the alex/optimizer_tfhers branch 2 times, most recently from 8796b5d to d540e48 Compare November 7, 2024 14:02
@aPere3 aPere3 changed the title [WIP] Optimizer support for TFHE-RS Optimizer support for TFHE-RS Nov 7, 2024
@aPere3 aPere3 changed the title Optimizer support for TFHE-RS Search space restriction Nov 7, 2024
@aPere3 aPere3 force-pushed the alex/optimizer_tfhers branch from d540e48 to 6e35b76 Compare November 7, 2024 14:07
@aPere3 aPere3 force-pushed the alex/optimizer_tfhers branch 2 times, most recently from fca910d to 0fccfbf Compare November 12, 2024 14:39
@BourgerieQuentin
Copy link
Member

cc @jdmarsh the API you do will change with this PR

@aPere3 aPere3 force-pushed the alex/optimizer_tfhers branch 3 times, most recently from 3849f7c to 09894b6 Compare November 14, 2024 13:38
@aPere3 aPere3 force-pushed the alex/optimizer_tfhers branch from 09894b6 to f70a18b Compare November 14, 2024 13:44
@aPere3 aPere3 merged commit b796dc8 into main Nov 15, 2024
31 checks passed
@aPere3 aPere3 deleted the alex/optimizer_tfhers branch November 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants