Compile in-memory MLIR Module #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
force-pushed
the
feat/compile-in-memory-module
branch
from
636c338
to
8ce5631
Compare
andidr
requested changes
Jul 20, 2023
compilers/concrete-compiler/compiler/include/concretelang/Support/LibrarySupport.h
Show resolved
Hide resolved
compilers/concrete-compiler/compiler/include/concretelang/Support/LibrarySupport.h
Show resolved
Hide resolved
youben11
force-pushed
the
feat/compile-in-memory-module
branch
from
8ce5631
to
e66cd37
Compare
Wasn't pushed sorry, here it is now https://github.com/zama-ai/concrete/pull/514/files#diff-6c99c7044f07fa639e664b590c593a676fbb5a73a1f52b7d267a950825a44038R161 |
umut-sahin
approved these changes
Jul 21, 2023
Comment on lines
+168
to
+169
| mlir_to_compile = mlir if isinstance(mlir, str) else str(mlir) | ||
| compilation_result = support.compile(mlir_to_compile, options) |
There was a problem hiding this comment.
We don't have support for in memory modules in jit?
youben11
force-pushed
the
feat/compile-in-memory-module
branch
from
09c7ca5
to
2e7c9e2
Compare
youben11
force-pushed
the
feat/compile-in-memory-module
branch
from
2e7c9e2
to
882de25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.