feat(frontend-python): dynamic assignment #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BourgerieQuentin
approved these changes
Jun 4, 2024
Not exactly all. We still don't support ellipsis and boolean array indexing. But it's pretty close.
I don't think it's necessary, it's such a common numpy operation, I think the users already know how to use it. All we can/should do is to support it as much as possible and emit good error messages when we don't support an operation. I'll make the CI green and merge 👍 |
umut-sahin
force-pushed
the
feat/dynamic-assignment
branch
from
1319bc4
to
1700cc6
Compare
umut-sahin
force-pushed
the
feat/dynamic-assignment
branch
from
1700cc6
to
9e80795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.