-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend-python): simulate encrypt run decrypt option #892
Conversation
I should not be the only reviewer, adding @BourgerieQuentin eg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but:
- I would prefer another tech person from Concrete to have a look
- I think we should have a test to check it's really done in simulation (for now, the test just checks it works)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, but that's really extremely dangerous as we have the same path for unencrypted and encrypted execution.
Should be added to the documentation.
5f6b787
to
825bd90
Compare
I've updated the documentation. |
We mentioned in slack (https://zama-ai.slack.com/archives/C0455QDGT6C/p1718354251437129?thread_ts=1718196499.461079&cid=C0455QDGT6C and thread) that the dangerous option can't be used in deployment so nothing bad can happen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. I challenge a bit the doc here, and also, feel free to resolve them, but I would have more comments, eg in test files to explain why you do that
Done! |
825bd90
to
ba46de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
(closes https://github.com/zama-ai/concrete-internal/issues/734)