Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend-python): simulate encrypt run decrypt option #892

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

umut-sahin
Copy link
Contributor

@bcm-at-zama
Copy link
Contributor

I should not be the only reviewer, adding @BourgerieQuentin eg

Copy link
Contributor

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but:

  • I would prefer another tech person from Concrete to have a look
  • I think we should have a test to check it's really done in simulation (for now, the test just checks it works)

Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, but that's really extremely dangerous as we have the same path for unencrypted and encrypted execution.
Should be added to the documentation.

@umut-sahin umut-sahin force-pushed the feat/simulate-encrypt-run-decrypt branch from 5f6b787 to 825bd90 Compare June 14, 2024 13:28
@umut-sahin
Copy link
Contributor Author

I've updated the documentation.

@bcm-at-zama
Copy link
Contributor

Look good to me, but that's really extremely dangerous as we have the same path for unencrypted and encrypted execution. Should be added to the documentation.

We mentioned in slack (https://zama-ai.slack.com/archives/C0455QDGT6C/p1718354251437129?thread_ts=1718196499.461079&cid=C0455QDGT6C and thread) that the dangerous option can't be used in deployment so nothing bad can happen

Copy link
Contributor

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I challenge a bit the doc here, and also, feel free to resolve them, but I would have more comments, eg in test files to explain why you do that

@umut-sahin
Copy link
Contributor Author

Done!

@umut-sahin umut-sahin force-pushed the feat/simulate-encrypt-run-decrypt branch from 825bd90 to ba46de0 Compare June 14, 2024 13:36
Copy link
Contributor

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@umut-sahin umut-sahin merged commit 5f2afc4 into main Jun 14, 2024
30 of 33 checks passed
@umut-sahin umut-sahin deleted the feat/simulate-encrypt-run-decrypt branch June 14, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants