Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(frontend): adding a use-case for fuzzy encrypted name comparison #995

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

bcm-at-zama
Copy link
Contributor

We have discussed with @GBAZama that it may be useful to show how to do IBAN name comparisons with Concrete. Let me try a small notebook which does that, feedback is welcome!

Copy link
Contributor Author

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making my own review: I'll need to re-run the benchmarks and run the command lines, to check nothing was broken. I'll do it when I have answered your reviews

@bcm-at-zama bcm-at-zama force-pushed the iban_use_case branch 2 times, most recently from 6fa49e4 to 7ef174b Compare August 13, 2024 13:40
@bcm-at-zama bcm-at-zama marked this pull request as ready for review August 13, 2024 14:43
Copy link
Contributor

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice example, thanks!

@bcm-at-zama bcm-at-zama force-pushed the iban_use_case branch 2 times, most recently from c280bdd to c1db673 Compare August 19, 2024 11:15
@bcm-at-zama
Copy link
Contributor Author

Better now, @umut-sahin ?

@bcm-at-zama
Copy link
Contributor Author

@umut-sahin : can we merge, then?

@bcm-at-zama bcm-at-zama merged commit 956a3df into main Aug 21, 2024
27 of 33 checks passed
@bcm-at-zama bcm-at-zama deleted the iban_use_case branch August 21, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants