-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(frontend): adding a use-case for fuzzy encrypted name comparison #995
Conversation
1d23683
to
706bb1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making my own review: I'll need to re-run the benchmarks and run the command lines, to check nothing was broken. I'll do it when I have answered your reviews
706bb1e
to
f74708b
Compare
frontends/concrete-python/examples/levenshtein_distance/IBAN_name_check.ipynb
Show resolved
Hide resolved
6fa49e4
to
7ef174b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice example, thanks!
frontends/concrete-python/examples/levenshtein_distance/IBAN_name_check.ipynb
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/IBAN_name_check.ipynb
Show resolved
Hide resolved
c280bdd
to
c1db673
Compare
Better now, @umut-sahin ? |
@umut-sahin : can we merge, then? |
c1db673
to
fdde6cd
Compare
We have discussed with @GBAZama that it may be useful to show how to do IBAN name comparisons with Concrete. Let me try a small notebook which does that, feedback is welcome!