feat: initial draft implementation #330
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcm-at-zama
reviewed
Feb 20, 2025
mortendahl
reviewed
Feb 20, 2025
| metadata[..60].copy_from_slice(front.as_slice()); | ||
| metadata[60..].copy_from_slice(&chain_id_bytes); | ||
|
|
||
| // TODO: How to build metadata for the proof? |
There was a problem hiding this comment.
Check with what's happening in fhevmjs: the data must be paid out in the same way
| .await?; | ||
| } | ||
| Err(ExecutionError::InvalidProof(_)) => { | ||
| // TODO: Should we mark the proof as invalid in the database? |
There was a problem hiding this comment.
I don't know if that's relevant here, but if the proof fails we want the verifier to send an (error) transaction back to the HTTPZ Gateway, instead of just ignoring the request.
There was a problem hiding this comment.
It is relevant here, but also in the:
- transaction-sender
- ZKProofManager contract
Maybe can be done in a later sprint if not implemented in the ZKProofManager contract yet.
dartdart26
reviewed
Feb 20, 2025
dartdart26
reviewed
Feb 20, 2025
dartdart26
reviewed
Feb 20, 2025
goshawk-3
force-pushed
the
georgi/zkproof-basic-impl
branch
from
a17068d to
8247fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.