Custom parameters for fhevm-go #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartdart26
requested changes
Nov 7, 2023
fhevm/interface.go
Outdated
| @@ -32,6 +32,7 @@ type EVMEnvironment interface { | |||
| CreateContract2(caller common.Address, code []byte, codeHash common.Hash, gas uint64, value *big.Int, address common.Address) ([]byte, common.Address, uint64, error) | |||
|
|
|||
| GetFhevmData() *FhevmData | |||
There was a problem hiding this comment.
Nit: Maybe we can rename GetFhevmData() to FhevmData() too. Not part of this PR, just noticed.
fhevm/params.go
Outdated
Comment on lines
94
to
104
| // TODO: The values here are chosen somewhat arbitrarily (at least the 8 bit ones). Also, we don't | ||
| // take into account whether a ciphertext existed (either "current" or "original") for the given handle. | ||
| // Finally, costs are likely to change in the future. | ||
| FheUint8ProtectedStorageSstoreGas uint64 = EvmNetSstoreInitGas + 2000 | ||
| FheUint16ProtectedStorageSstoreGas uint64 = FheUint8ProtectedStorageSstoreGas * 2 | ||
| FheUint32ProtectedStorageSstoreGas uint64 = FheUint16ProtectedStorageSstoreGas * 2 | ||
|
|
||
| // TODO: We don't take whether the slot is cold or warm into consideration. | ||
| FheUint8ProtectedStorageSloadGas uint64 = ColdSloadCostEIP2929 + 200 | ||
| FheUint16ProtectedStorageSloadGas uint64 = FheUint8ProtectedStorageSloadGas * 2 | ||
| FheUint32ProtectedStorageSloadGas uint64 = FheUint16ProtectedStorageSloadGas * 2 |
There was a problem hiding this comment.
I think we should not remove these. Instead, if they are unused, I think it indicates another issue in that we don't charge for protected storage.
|
@dartdart26 restored deleted constants, renamed also |
dartdart26
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds clear api to customize fhevm-go, user needs to provide *FhevmParams struct, defaults exist but can be customized by user
@dartdart26 @youben11