Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fhe lib precompile and Makefile #4

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

david-zk
Copy link
Collaborator

@david-zk david-zk commented Oct 4, 2023

Added fheLib precompile with fheAdd, nothing is tested yet, just compiling with refactored interfaces.
Also, added very basic initial Makefile. Will make further changes as needed to make avax subnet work.
Still need to build tfhe-rs lib.

@dartdart26 @youben11

Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good!

The only thing we should change is geth's version to 1.12.0 as we discussed offline.

@david-zk
Copy link
Collaborator Author

@dartdart26 downgraded in 9f64b2b commit

Copy link
Collaborator

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dartdart26
Copy link
Collaborator

Looks good!

Actually, @david-zama can you change your PR to merge to the v0.5.6-zama branch?

@david-zk david-zk changed the base branch from main to v0.5.6-zama October 10, 2023 06:31
@david-zk david-zk merged commit 9f71d85 into v0.5.6-zama Oct 10, 2023
@david-zk david-zk deleted the add-precompiles branch October 10, 2023 06:31
@david-zk
Copy link
Collaborator Author

@dartdart26 done, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants