Refactor TFHE #79
Merged
Refactor TFHE #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
force-pushed
the
refactor/tfhe
branch
from
63c32c9
to
84b655c
Compare
dartdart26
reviewed
Feb 8, 2024
| @@ -0,0 +1,2124 @@ | |||
| #include "tfhe_wrappers.h" | |||
There was a problem hiding this comment.
Not related to this PR, but with so much C code, we need to add some tooling to check for memory errors/leaks.
There was a problem hiding this comment.
And/or use auto-generation of the wrappers to reduce the risk of a bug.
There was a problem hiding this comment.
For the first point, I can look into that, and also make sure the Go build does use hardening flags during compilation maybe.
For the second point, I need to look deeper into the wrappers to see if there is anything we can automate here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.