fix(gpu): fix compression #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdroalves
force-pushed
the
pa/fix/multigpu_compression
branch
3 times, most recently
from
63ffe07 to
b555014
Compare
agnesLeroy
force-pushed
the
pa/fix/multigpu_compression
branch
from
b555014 to
207f689
Compare
pdroalves
force-pushed
the
pa/fix/multigpu_compression
branch
2 times, most recently
from
9c18d2d to
6f9337e
Compare
pdroalves
changed the title
pdroalves
force-pushed
the
pa/fix/multigpu_compression
branch
5 times, most recently
from
5bf3a50 to
8333a66
Compare
|
Now we can run compression benchmarks using the target |
pdroalves
force-pushed
the
pa/fix/multigpu_compression
branch
2 times, most recently
from
e525fae to
4611054
Compare
agnesLeroy
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Hey @pdroalves! Thanks a lot for this fix: I just have one question, just to check the additional argument bodies_count is necessary 🙂
backends/tfhe-cuda-backend/cuda/src/integer/compression/compression.cu
Outdated
Show resolved
Hide resolved
pdroalves
force-pushed
the
pa/fix/multigpu_compression
branch
from
4611054 to
3d85789
Compare
pdroalves
force-pushed
the
pa/fix/multigpu_compression
branch
from
3d85789 to
bc9d7a6
Compare
agnesLeroy
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some edge cases, including booleans and multi-gpu.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/686
PR content/description
Check-list: