Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use python script to send benchmark results #1516

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Sep 6, 2024

Using this script simplify writing of corresponding workflow step. Moreover, now when an upload fails it translate into a workflow failure.

This needs to wait for new release of Slab to shipped to production before merging.

@soonum soonum added the ci label Sep 6, 2024
@soonum soonum requested a review from IceTDrinker September 6, 2024 10:24
@soonum soonum self-assigned this Sep 6, 2024
@cla-bot cla-bot bot added the cla-signed label Sep 6, 2024
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is there a way to do a workflow dispatch on this PR to see if it works as expected ?

Using this script simplify writing of corresponding workflow step.
Moreover, now when an upload fails it translate into a workflow
failure.
@soonum soonum force-pushed the dt/ci/data_send_python branch from 3de8c06 to bcecb9b Compare September 9, 2024 07:36
@soonum
Copy link
Contributor Author

soonum commented Sep 9, 2024

I've just tried on boolean benchmarks and it worked (after having fixed the name of the script)

@soonum soonum merged commit 6544e6f into main Sep 9, 2024
35 checks passed
@soonum soonum deleted the dt/ci/data_send_python branch September 9, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants