Am/feat/zk metadata #1522
Merged
Am/feat/zk metadata #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
force-pushed
the
am/feat/zk-metadata
branch
2 times, most recently
from
ef64924 to
3ac33b0
Compare
|
Check for the wasm test change https://github.com/zama-ai/tfhe-rs/actions/runs/10806528752 |
IceTDrinker
force-pushed
the
am/feat/zk-metadata
branch
from
3ac33b0 to
a18f839
Compare
|
new run https://github.com/zama-ai/tfhe-rs/actions/runs/10807698866 (forgot to format something in the previous one) |
|
test is failing locally :/ we don't get the feedback, we need to get this python test runne ASAP |
IceTDrinker
force-pushed
the
am/feat/zk-metadata
branch
from
a18f839 to
bfc4e7b
Compare
IceTDrinker
force-pushed
the
am/feat/zk-metadata
branch
from
bfc4e7b to
e5c7e0a
Compare
nsarlin-zama
approved these changes
Sep 11, 2024
- proof function takes an additional u8 slice which is hashed in the proof the verification cannot happen without the same metadata being provided again
IceTDrinker
force-pushed
the
am/feat/zk-metadata
branch
from
e5c7e0a to
99bcb85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.