Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gpu): fix comparisons #1554

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix(gpu): fix comparisons #1554

merged 1 commit into from
Sep 18, 2024

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2024
IceTDrinker
IceTDrinker approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! This matches the CPU code as far as I can tell so thanks 👍

@agnesLeroy agnesLeroy merged commit a6aa95c into main Sep 18, 2024
85 of 87 checks passed
@agnesLeroy agnesLeroy deleted the al/fix_comparisons branch September 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker approved these changes

@pdroalves pdroalves Awaiting requested review from pdroalves

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @IceTDrinker @zama-bot