Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integer): fix max_noise_level to keep space for carry #1632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(integer): fix max_noise_level to keep space for carry #1632

wants to merge 1 commit into from

Conversation

mayeul-zama
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 4, 2024
IceTDrinker
IceTDrinker requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this is safe to do as integer algorithms often fill the noise and don’t need to propagate carries all the time, to be checked with @tmontaigu

@IceTDrinker
Copy link
Member

if we do this I would keep a max_noise_level, max_noise_level_to_allow_carry_propagation, and probably something similar for the max degree stuff, as the max degree is dictated by parameters

@tmontaigu
Copy link
Contributor

This would'break' max_sum_size as it needs to use the 'true' max degree (i.e the one without the space left for a carry addition)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayeul-zama @IceTDrinker @tmontaigu