Fix: degree for min max

[Tuditi]

PR content/description

Contains a test to recreate an issue we have been having at Belfort. The min - max functions seem to fail at the assertion that the carries are empty. IIUC, this is due to the fact that unchecked_add will add together the degrees, but we know that either the LHS or the RHS will be set to 0 after performing the LUT here.

It can be solved in the following ways:

1. Set the degree to Degree::new(msg_modulus - 1).
2. Add a remainder operation in the LUTs (% message_modulus).
3. Calculate the maximum degree before applying the additions and the LUTs.

• Which one is your preferred solution?

Check-list:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Relevant issues are marked as resolved/closed, related issues are linked in the description
• Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tuditi.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tuditi.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tuditi.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[tmontaigu]

While the fix to set the degree is correct and should be kept, you are not using the correct test

This makes you believe the function is incorrect but it is.
You are putting an unchecked_ function to a function designed to test a "default" so test gives inputs that are not meant to be handled by an unchecked function and the test also does post condition checks that are not meant for unchecked function.

Also you should use the _parallelized version, its faster and more efficient

[tmontaigu]

Here also you have to do a make fmt and fix any make clippy_integer errors

[Tuditi]

Here also you have to do a make fmt and fix any make clippy_integer errors

Done :)