string server key wrapper #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeul-zama
force-pushed
the
mz/string_server_key
branch
from
f265684 to
bc1e637
Compare
mayeul-zama
force-pushed
the
mz/strings_function_executor
branch
2 times, most recently
from
459520a to
b3d07ca
Compare
mayeul-zama
force-pushed
the
mz/string_server_key
branch
from
bc1e637 to
7de4172
Compare
mayeul-zama
force-pushed
the
mz/strings_function_executor
branch
from
b3d07ca to
c525180
Compare
mayeul-zama
force-pushed
the
mz/string_server_key
branch
from
7de4172 to
f57b9c3
Compare
mayeul-zama
force-pushed
the
mz/strings_function_executor
branch
2 times, most recently
from
9fe1dc5 to
1dc8d94
Compare
mayeul-zama
force-pushed
the
mz/string_server_key
branch
from
f57b9c3 to
b6d66a9
Compare
mayeul-zama
force-pushed
the
mz/strings_function_executor
branch
from
1dc8d94 to
a65fb98
Compare
tmontaigu
reviewed
Dec 4, 2024
mayeul-zama
force-pushed
the
mz/string_server_key
branch
from
b6d66a9 to
ce5c830
Compare
mayeul-zama
force-pushed
the
mz/string_server_key
branch
from
ce5c830 to
2d3b17e
Compare
|
Since the string function are tied to a different key than integer key, should we remove the 'string' prefix from functions found in comp.rs (string_le, string_eq, etc) ? |
Most likely_yes |
tmontaigu
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.