fix(shortint): fix compression encoding change not being taken into account #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
force-pushed
the
am/fix/compression
branch
2 times, most recently
from
25b09ef to
adbd9df
Compare
|
@IceTDrinker is this something we also have to take into account for the GPU compression? |
Oh yes sorry, forgot about the GPU implem, though to be clear the pfail is already super low with the bug, but for now I would say it’s better to update the encoding to have an even lower pfail at compression time |
mayeul-zama
reviewed
Dec 11, 2024
IceTDrinker
force-pushed
the
am/fix/compression
branch
from
adbd9df to
bbe2888
Compare
…ccount - this maps better to what was optimized and will dramatically diminish the pfail as we now have 2 more bits for the LUT redundancy
IceTDrinker
force-pushed
the
am/fix/compression
branch
from
bbe2888 to
204ea23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.