Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix concurrency group format on pull request event #1911

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Jan 3, 2025

Since the addition of pull_request_target event, github.ref context object return name of the base branch. So when a workflow was triggered on the base branch during an execution in a pull request, the latter would be cancelled.

Using github.head_ref, when available, fixes this behavior. On any other event than pull_request or pull_request_target, github.ref will still be used and work as before.

Since the addition of pull_request_target event, github.ref context
object return name of the base branch. So when a workflow was
triggered on the base branch during an execution in a pull request,
the latter would be cancelled.
Using github.head_ref, when available, fixes this behavior.
On any other event than pull_request or pull_request_target,
github.ref will still be used and work as before.
@soonum soonum added the ci label Jan 3, 2025
@soonum soonum requested a review from IceTDrinker January 3, 2025 14:24
@soonum soonum self-assigned this Jan 3, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 3, 2025
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@soonum soonum merged commit 9c43c30 into main Jan 3, 2025
218 of 219 checks passed
@soonum soonum deleted the dt/ci/fix_workflow_grouping branch January 3, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants