-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gpu): update multi-bit parameters #1961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
Jan 14, 2025
tfhe/src/shortint/parameters/v0_11/multi_bit/gaussian/p_fail_2_minus_64/ks_pbs_gpu.rs
Outdated
Show resolved
Hide resolved
agnesLeroy
force-pushed
the
al/update_multi_bit_params
branch
2 times, most recently
from
January 15, 2025 09:00
ea30c97
to
da70997
Compare
IceTDrinker
reviewed
Jan 15, 2025
agnesLeroy
force-pushed
the
al/update_multi_bit_params
branch
from
January 15, 2025 13:16
da70997
to
47e8df8
Compare
IceTDrinker
reviewed
Jan 15, 2025
agnesLeroy
force-pushed
the
al/update_multi_bit_params
branch
2 times, most recently
from
January 15, 2025 13:52
83490eb
to
5ddc8f8
Compare
IceTDrinker
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right waiting on the security test otherwise looks good
It passed |
IceTDrinker
approved these changes
Jan 15, 2025
agnesLeroy
force-pushed
the
al/update_multi_bit_params
branch
from
January 16, 2025 08:34
5ddc8f8
to
31c3544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: please link all relevant issues
PR content/description
Check-list: