Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(integer): add tests for default signed rotations/shifts #580

Merged
merged 1 commit into from
Oct 16, 2023
Merged

chore(integer): add tests for default signed rotations/shifts #580

merged 1 commit into from
Oct 16, 2023

Conversation

tmontaigu
Copy link
Contributor

  • Tests for the changes have been added (for bug fixes / features)

@cla-bot cla-bot bot added the cla-signed label Sep 22, 2023
@github-actions
Copy link

@slab-ci cpu_fast_test

@tmontaigu tmontaigu force-pushed the add-default-rotr-shifts-tests branch from 1f1a212 to 5c819e9 Compare September 22, 2023 14:02
@github-actions
Copy link

@slab-ci cpu_fast_test

@tmontaigu tmontaigu force-pushed the add-default-rotr-shifts-tests branch from 5c819e9 to d528598 Compare September 22, 2023 15:08
@github-actions
Copy link

@slab-ci cpu_fast_test

@tmontaigu tmontaigu force-pushed the add-default-rotr-shifts-tests branch from d528598 to c1c2676 Compare September 22, 2023 16:28
@github-actions
Copy link

@slab-ci cpu_fast_test

@tmontaigu tmontaigu force-pushed the add-default-rotr-shifts-tests branch from c1c2676 to 95f64bb Compare September 22, 2023 18:57
@github-actions
Copy link

@slab-ci cpu_fast_test

IceTDrinker
IceTDrinker reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments apply for the various tests

tfhe/src/integer/server_key/radix_parallel/tests_signed.rs Show resolved Hide resolved
tfhe/src/integer/server_key/radix_parallel/tests_signed.rs Show resolved Hide resolved
@github-actions
Copy link

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@tmontaigu tmontaigu force-pushed the add-default-rotr-shifts-tests branch from 95f64bb to 592a722 Compare October 2, 2023 06:59
@github-actions github-actions bot removed the approved label Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

@slab-ci cpu_fast_test

@tmontaigu tmontaigu requested a review from IceTDrinker October 2, 2023 12:00
@tmontaigu
Copy link
Contributor Author

Rebased on main to have fix for division

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@tmontaigu tmontaigu force-pushed the add-default-rotr-shifts-tests branch from 592a722 to 40033db Compare October 16, 2023 08:29
@github-actions github-actions bot removed the approved label Oct 16, 2023
@github-actions
Copy link

@slab-ci cpu_fast_test

@IceTDrinker
Copy link
Member

needs make fmt

@tmontaigu tmontaigu force-pushed the add-default-rotr-shifts-tests branch from 40033db to 5dfe215 Compare October 16, 2023 09:19
@github-actions
Copy link

@slab-ci cpu_fast_test

@github-actions
Copy link

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@tmontaigu tmontaigu merged commit bfdfbfa into main Oct 16, 2023
18 checks passed
@tmontaigu tmontaigu deleted the add-default-rotr-shifts-tests branch October 16, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmontaigu @IceTDrinker