fix(integer): handle trivial ct in if_then_else #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slab-ci cpu_fast_test |
if_then_else uses two calls to zero_out_if. In zero_out_if, if the condition block given has a degree of 0 then it would return 0, without calling the predicate function. This is not correct, as its the predicate function that gives whether the output should be 0 or the original ciphertext. Which meant that if if_then_else received a condition with a degree of 0, it would always return 0.
tmontaigu
force-pushed
the
fix-trivial-if-then-else
branch
from
31e7875 to
7e1a1ba
Compare
|
@slab-ci cpu_fast_test |
|
Pull Request has been approved 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if_then_else uses two calls to zero_out_if.
In zero_out_if, if the condition block given has a degree of 0
then it would return 0, without calling the predicate function.
This is not correct, as its the predicate function that
gives whether the output should be 0 or the original ciphertext.
Which meant that if if_then_else received a condition with a
degree of 0, it would always return 0.
Check-list: