Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boolean): add raw parts methods to the ClientKey #759

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

IceTDrinker
Copy link
Member

PR content/description

While working on forward compatibility it appears that some struct have no way of being deconstructed and reconstructed for data migration purposes.

This PR is a very small example on the boolean::ClientKey to align on the design of these APIs. Expect a lot of small PRs with a similar goal and once we agree here on the design, a very similar design.

This current patch is aimed at the release/0.4.x branch but will also be added to the main branch as the APIs to reconstruct will be used for data migration from 0.4 to 0.5 and later on deconstruction primitives will be used for migration from 0.5 to 0.6

added:

  • into_raw_parts allows to deconstruct a ClientKey
  • new_from_raw_parts allows to construct a ClientKey

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
    * [ ] Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

Copy link

github-actions bot commented Jan 4, 2024

@slab-ci cpu_fast_test

- into_raw_parts allows to deconstruct a ClientKey
- new_from_raw_parts allows to construct a ClientKey
@IceTDrinker IceTDrinker force-pushed the am/feat/boolean-raw-parts-cks branch from 8d48936 to fbb8688 Compare January 4, 2024 16:13
Copy link

github-actions bot commented Jan 4, 2024

@slab-ci cpu_fast_test

Copy link

github-actions bot commented Jan 5, 2024

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@IceTDrinker IceTDrinker merged commit 7ae5f65 into release/0.4.x Jan 8, 2024
19 checks passed
@IceTDrinker IceTDrinker deleted the am/feat/boolean-raw-parts-cks branch January 8, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants