Am/chore/fix deps pinning #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slab-ci cpu_test |
|
@slab-ci cpu_fast_test |
|
Already launched the tests as they are super long and the breakage is very bad |
|
I left my assert of the forward compat to test 🫠 |
IceTDrinker
force-pushed
the
am/chore/fix-deps-pinning
branch
from
09beb57 to
84e61c2
Compare
|
@slab-ci cpu_fast_test |
|
@slab-ci cpu_test |
|
@mayeul-zama the review is to spot stuff that may look odd, CI is already in progress so no need to approve, it would just re run it |
soonum
reviewed
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #931
Used allow everywhere as some changes would likely be semver breaking even if some stuff is unused