Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option :trim_whitespace to parser #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

clemensm
Copy link

Two options for disabling whitespace trimming have been added:

  1. Either pass trim_whitespace: false to Eml.parse() as an option
  2. For app wide override set
    config :eml, trim_whitespace: false

If both variants are used, the option passed directly to the parser will
override the app wide config.

If no option is given, true will be used as the default value and thus
keep the old behavior.

Reason for the change: I've got an app where we receive user created html (in froala) which we transform using Eml. However we sometimes got the problem that we've got spans in the html for the background color of some text, and currently Eml removes those whitespaces, something that is not expected by the end users.

So we've created this fork which simply adds the two options above, would be nice if you could merge it so that we can remove our own fork.

Clemens Müthing and others added 2 commits December 30, 2019 12:47
Two options for disabling whitespace trimming have been added:

1. Either pass trim_whitespace: false to Eml.parse() as an option
2. For app wide override set
     config :eml, trim_whitespace: false

If both variants are used, the option passed directly to the parser will
override the app wide config.

If no option is given, true will be used as the default value and thus
keep the old behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant