Added ability to create target server without ssl_info configuration #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
ApiGee target server behaves differently when created like:
{ "name" : "asdf-target", "host" : "host.123", "isEnabled" : true, "port" : 80, "sSLInfo": {} }and like:
{ "name" : "asdf-target", "host" : "host.123", "isEnabled" : true, "port" : 80 }So... there should be the ability to create such target server (without ssl_info object defined).
I have added that possibility, fixed acceptance tests for this resource and added new test checking new functionality. It would be great to have that merged :)
NOTE: small change in go-apigee-edge was needed to make it work (zambien/go-apigee-edge#10).