Skip to content

Commit

Permalink
Try upgrading NodeJS version to see if it helps with exit code 139 se…
Browse files Browse the repository at this point in the history
…gmentation fault after all frontend tests pass
  • Loading branch information
amosjyng committed May 19, 2024
1 parent bff58bd commit 8413bc0
Show file tree
Hide file tree
Showing 5 changed files with 2,513 additions and 2,422 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: publish
on: workflow_dispatch

env:
NODEJS_VERSION: "20.5.1"
NODEJS_VERSION: "22.2.0"
RUST_VERSION: "1.76.0"
GITHUB_TOKEN: ${{ secrets.FONTS_PAT }}
TAURI_PRIVATE_KEY: ${{ secrets.TAURI_PRIVATE_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

env:
POETRY_VERSION: "1.5.1"
NODEJS_VERSION: "20.5.1"
NODEJS_VERSION: "22.2.0"
RUST_VERSION: "1.76.0"
PRE_COMMIT_VERSION: "3.6.0"
TAURI_CLI_VERSION: "1.5.9"
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RUN curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain ${RUST_VERS
ENV PATH="/root/.cargo/bin:${PATH}"
RUN cargo install --locked tauri-cli@${TAURI_CLI_VERSION}

ARG NODEJS_VERSION=20.5.1
ARG NODEJS_VERSION=22.2.0
WORKDIR /tmp
RUN curl -SLO "https://nodejs.org/dist/v${NODEJS_VERSION}/node-v${NODEJS_VERSION}-linux-x64.tar.xz" && \
tar -xJf "node-v${NODEJS_VERSION}-linux-x64.tar.xz" -C /usr/local --strip-components=1 && \
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.PHONY: rust-format rust-lint quicktype

BUILD_IMAGE = ghcr.io/amosjyng/zamm:v0.1.1-build
BUILD_IMAGE = ghcr.io/amosjyng/zamm:v0.1.4-build
CURRENT_DIR = $(shell pwd)

build: svelte rust
Expand Down
Loading

0 comments on commit 8413bc0

Please sign in to comment.