Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initJob.podSpec #298

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add initJob.podSpec #298

wants to merge 3 commits into from

Conversation

klml
Copy link
Contributor

@klml klml commented Oct 7, 2024

What this PR does / why we need it

Adds podSpec to the initJob

Which issue this PR fixes

With this PR I can add

  initJob:
    podSpec:
      activeDeadlineSeconds: 1337

and fix #297

Checklist

  • Chart Version bumped

zammad/Chart.yaml Outdated Show resolved Hide resolved
@klml klml requested a review from monotek October 7, 2024 15:55
Copy link
Collaborator

@mgruner mgruner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Do you think we could add this to init-podspec/zammad/ci/full-values.yaml? This file is used in CI by chart-testing to create a cluster with a lot of possible value customizations to ensure it can still be installed and started properly?

@klml
Copy link
Contributor Author

klml commented Oct 11, 2024

@mgruner I added podSpec activeDeadlineSeconds 1337 or should I use other example values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: activeDeadlineSeconds
3 participants