Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deployment strategy: Recreate for scheduler and websocket deployments to avoid coexisting replicas #318

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

klml
Copy link
Contributor

@klml klml commented Feb 5, 2025

What this PR does / why we need it

Currently the scheduler is RollingUpdate (it is the default value). This leads to an small time period with 2 schedulers.

But the scheduler may only run once per cluster..

Changing deployment strategy to Recreate Deployment

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Upgrading instructions are documented in the zammad/README.md

	modified:   zammad/Chart.yaml
@mgruner
Copy link
Collaborator

mgruner commented Feb 5, 2025

This is great @klml. We'd also need to apply this to the websocket server, can you please include it here?

@mgruner mgruner changed the title scheduler deployment strategy: Recreate Use deployment strategy: Recreate for scheduler and websocket deployments to avoid coexisting replicas Feb 6, 2025
@mgruner mgruner merged commit 77ab5a8 into zammad:main Feb 6, 2025
8 checks passed
@mgruner
Copy link
Collaborator

mgruner commented Feb 6, 2025

👏 thanks a lot @klml! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants