Skip to content

Commit

Permalink
[VM interpreter] Disable code optimization when running interpreted t…
Browse files Browse the repository at this point in the history
…ests.

Change-Id: Ie8be83b5223db5c73d0d98ddc03e26d757d1ea29
Reviewed-on: https://dart-review.googlesource.com/70480
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
  • Loading branch information
crelier authored and commit-bot@chromium.org committed Aug 17, 2018
1 parent 891b716 commit 2c6ad6e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/language_2/language_2_kernel.status
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,9 @@ compile_time_constant_o_test/02: Pass
const_dynamic_type_literal_test/02: Pass
map_literal3_test/01: Pass
map_literal3_test/02: Pass
vm/causal_async_exception_stack2_test: RuntimeError # No support for line numbers in stacktraces
vm/causal_async_exception_stack_test: RuntimeError # No support for line numbers in stacktraces
vm/regress_28325_test: RuntimeError # No support for line numbers in stacktraces

[ $compiler == dartkp && $mode == debug && $runtime == dart_precompiled && $strong ]
const_instance_field_test/01: Crash # Issue 32326.
Expand Down
2 changes: 2 additions & 0 deletions tools/testing/dart/runtime_configuration.dart
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
if (suite.configuration.compiler == Compiler.dartkb) {
args.removeWhere(
(String arg) => arg.startsWith('--optimization-counter-threshold'));
args.removeWhere(
(String arg) => arg.startsWith('--optimization_counter_threshold'));
args = <String>['--optimization-counter-threshold=-1']..addAll(args);
}

Expand Down

0 comments on commit 2c6ad6e

Please sign in to comment.