Skip to content

Commit

Permalink
net: ll_temac: Make some functions static
Browse files Browse the repository at this point in the history
Fix sparse warnings:

drivers/net/ethernet/xilinx/ll_temac_main.c:66:5: warning: symbol '_temac_ior_be' was not declared. Should it be static?
drivers/net/ethernet/xilinx/ll_temac_main.c:71:6: warning: symbol '_temac_iow_be' was not declared. Should it be static?
drivers/net/ethernet/xilinx/ll_temac_main.c:76:5: warning: symbol '_temac_ior_le' was not declared. Should it be static?
drivers/net/ethernet/xilinx/ll_temac_main.c:81:6: warning: symbol '_temac_iow_le' was not declared. Should it be static?
drivers/net/ethernet/xilinx/ll_temac_main.c:648:6: warning: symbol 'ptr_to_txbd' was not declared. Should it be static?
drivers/net/ethernet/xilinx/ll_temac_main.c:654:6: warning: symbol 'ptr_from_txbd' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
YueHaibing authored and davem330 committed May 5, 2019
1 parent 44bec4b commit 6e05b83
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/net/ethernet/xilinx/ll_temac_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,22 +63,22 @@
* Low level register access functions
*/

u32 _temac_ior_be(struct temac_local *lp, int offset)
static u32 _temac_ior_be(struct temac_local *lp, int offset)
{
return ioread32be(lp->regs + offset);
}

void _temac_iow_be(struct temac_local *lp, int offset, u32 value)
static void _temac_iow_be(struct temac_local *lp, int offset, u32 value)
{
return iowrite32be(value, lp->regs + offset);
}

u32 _temac_ior_le(struct temac_local *lp, int offset)
static u32 _temac_ior_le(struct temac_local *lp, int offset)
{
return ioread32(lp->regs + offset);
}

void _temac_iow_le(struct temac_local *lp, int offset, u32 value)
static void _temac_iow_le(struct temac_local *lp, int offset, u32 value)
{
return iowrite32(value, lp->regs + offset);
}
Expand Down Expand Up @@ -645,25 +645,25 @@ static void temac_adjust_link(struct net_device *ndev)

#ifdef CONFIG_64BIT

void ptr_to_txbd(void *p, struct cdmac_bd *bd)
static void ptr_to_txbd(void *p, struct cdmac_bd *bd)
{
bd->app3 = (u32)(((u64)p) >> 32);
bd->app4 = (u32)((u64)p & 0xFFFFFFFF);
}

void *ptr_from_txbd(struct cdmac_bd *bd)
static void *ptr_from_txbd(struct cdmac_bd *bd)
{
return (void *)(((u64)(bd->app3) << 32) | bd->app4);
}

#else

void ptr_to_txbd(void *p, struct cdmac_bd *bd)
static void ptr_to_txbd(void *p, struct cdmac_bd *bd)
{
bd->app4 = (u32)p;
}

void *ptr_from_txbd(struct cdmac_bd *bd)
static void *ptr_from_txbd(struct cdmac_bd *bd)
{
return (void *)(bd->app4);
}
Expand Down

0 comments on commit 6e05b83

Please sign in to comment.