Skip to content

Commit

Permalink
ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode
Browse files Browse the repository at this point in the history
BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
packet loss rates. The realtek phy driver overrides the settings of the
pull ups for the delays, so fix this for BananaPro.

Fix the phy-mode description to correctly reflect this so that the
implementation doesn't reconfigure the delays incorrectly. This
happened with commit bbc4d71 ("net: phy: realtek: fix rtl8211e
rx/tx delay config").

Fixes: 10662a3 ("ARM: dts: sun7i: Add dts file for Bananapro board")
Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20210128111842.GA11919@lemon.iwr.uni-heidelberg.de
  • Loading branch information
Hermann Lauer authored and mripard committed Feb 3, 2021
1 parent 530fe6b commit a900cac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/sun7i-a20-bananapro.dts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
phy-mode = "rgmii";
phy-mode = "rgmii-id";
phy-supply = <&reg_gmac_3v3>;
status = "okay";
};
Expand Down

0 comments on commit a900cac

Please sign in to comment.