Skip to content

Commit

Permalink
Hack
Browse files Browse the repository at this point in the history
  • Loading branch information
zanmato1984 committed Aug 30, 2024
1 parent 4746bd2 commit e532545
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
10 changes: 6 additions & 4 deletions cpp/src/arrow/acero/swiss_join.cc
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,12 @@ Status RowArray::DecodeSelected(ResizableArrayData* output, int column_id,
// Process nulls
//
#ifdef ARROW_HAVE_RUNTIME_AVX2
if (use_avx2) {
num_rows_processed =
DecodeNulls_avx2(output, num_rows_before, column_id, num_rows_to_append, row_ids);
}
// if (use_avx2) {
// num_rows_processed =
// DecodeNulls_avx2(output, num_rows_before, column_id, num_rows_to_append,
// row_ids);
// }
num_rows_processed = 0;
#endif
DecodeNulls(output, num_rows_before + num_rows_processed, column_id,
num_rows_to_append - num_rows_processed, row_ids + num_rows_processed);
Expand Down
14 changes: 7 additions & 7 deletions cpp/src/arrow/acero/swiss_join_avx2.cc
Original file line number Diff line number Diff line change
Expand Up @@ -405,11 +405,11 @@ int RowArray::DecodeFixedLength_avx2(ResizableArrayData* output, int output_star
// off the cost of the heavy gather instructions.
// For fixed length 0 (boolean column), the vectorized code wins by batching 8 bits into
// a single byte instead of modifying the same byte 8 times in the scalar code.
if (!(fixed_length == 0 || fixed_length > 8)) {
DecodeFixedLength(output, output_start_row, column_id, fixed_length,
num_rows_to_append, row_ids);
return num_rows_to_append;
}
// if (!(fixed_length == 0 || fixed_length > 8)) {
// DecodeFixedLength(output, output_start_row, column_id, fixed_length,
// num_rows_to_append, row_ids);
// return num_rows_to_append;
// }

DCHECK_EQ(output_start_row % 8, 0);

Expand Down Expand Up @@ -484,8 +484,8 @@ int RowArray::DecodeOffsets_avx2(ResizableArrayData* output, int output_start_ro
int column_id, int num_rows_to_append,
const uint32_t* row_ids) const {
// Same reason as DecodeFixedLength_avx2.
DecodeOffsets(output, output_start_row, column_id, num_rows_to_append, row_ids);
return num_rows_to_append;
// DecodeOffsets(output, output_start_row, column_id, num_rows_to_append, row_ids);
// return num_rows_to_append;

uint32_t* offsets =
reinterpret_cast<uint32_t*>(output->mutable_data(1)) + output_start_row;
Expand Down

0 comments on commit e532545

Please sign in to comment.