Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem sourcing the spaceship-promt theme #118

Closed
trimclain opened this issue Mar 3, 2023 · 2 comments · Fixed by #119
Closed

Problem sourcing the spaceship-promt theme #118

trimclain opened this issue Mar 3, 2023 · 2 comments · Fixed by #119

Comments

@trimclain
Copy link
Contributor

Describe the bug

I tried installing the spaceship-promt theme and got the message that it wasn't activated. After going through the code I found out,
that when zap sources the plugin, it uses the plugin name and the extension to find the file to source. In case of spaceship-promt the file is actually called spaceship.zsh-theme.

Steps to reproduce

plug "spaceship-prompt/spaceship-prompt"

Expected behavior

Install and enable the theme

Screenshots and recordings

No response

OS / Linux distribution

Ubuntu 22.04

Zsh version

5.8.1

Zap version

v0.2.0 on commit 3564bef

Terminal emulator

kitty

If using WSL on Windows, which version of WSL

None

Additional context

No response
@trimclain
Copy link
Contributor Author

I just found your note about this in the README.
Are you interested in fixing this issue? I could try to do it.

@mamaraddio
Copy link
Member

Sure, try it and do a pull request.
We will look at your code

@mamaraddio mamaraddio linked a pull request Mar 11, 2023 that will close this issue
feat: search for the plugin file to source (close #118) #119
Merged
mamaraddio pushed a commit that referenced this issue Mar 12, 2023
@trimclain
feat: search for the plugin file to source (close #118) (#119)
ca9e52d 
* Update zap.zsh

* Update README.md

* Update zap.zsh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: search for the plugin file to source (close #118) trimclain/zap
2 participants
@mamaraddio @trimclain