Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup directories #104

Merged
merged 2 commits into from
Jan 16, 2023
Merged

feat: cleanup directories #104

merged 2 commits into from
Jan 16, 2023

Conversation

wintermi
Copy link
Contributor

  1. fix: remove the duplicate and misspelt directory '.github/ISSUE_TAMPLATE'
  2. feat: move the plugins directory to be part of the repo

@mamaraddio
Copy link
Member

I don't know if plugins dir should be part of the repo tho. At the end of the day it will be always empty. Maybe I'm wrong, but why do you think it should be there?

@wintermi
Copy link
Contributor Author

I don't know if plugins dir should be part of the repo tho. At the end of the day it will be always empty. Maybe I'm wrong, but why do you think it should be there?

Removes the need to perform the mkdir which itself could be prone to failure.

@mamaraddio
Copy link
Member

I don't know if plugins dir should be part of the repo tho. At the end of the day it will be always empty. Maybe I'm wrong, but why do you think it should be there?

Removes the need to perform the mkdir which itself could be prone to failure.

Ok, that could be a good point. I'll merge your PR

@mamaraddio
Copy link
Member

mamaraddio commented Jan 16, 2023

What is the plugins/.gitkeep file?

@wintermi
Copy link
Contributor Author

What is the plugins/.gitkeep file?

This is a 0 byte file use to ensure the empty directory is stored within the git repo, otherwise by default git would not add an empty directory.

@mamaraddio
Copy link
Member

What is the plugins/.gitkeep file?

This is a 0 byte file use to ensure the empty directory is stored within the git repo, otherwise by default git would not add an empty directory.

Ok, I learned something new 🙂

@mamaraddio mamaraddio merged commit 4fc2dbf into zap-zsh:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants