feat: if plug dirname exists then local source only #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamaraddio
approved these changes
Jan 26, 2023
zap.zsh
Outdated
| @@ -16,7 +16,12 @@ function plug() { | |||
| done | |||
| } | |||
|
|
|||
| [[ -f "$1" ]] && source "$1" && return 0 | |||
| # If the directory exists, then local source only | |||
| if [ -d $(dirname "$1") ]; then | |||
There was a problem hiding this comment.
if [ -d "${1:h}" ]; then
This seams to work better and uses ZSH built-in substitution instead of os commands
| # If the directory exists, then local source only | ||
| if [ -d $(dirname "$1") ]; then | ||
| [[ -f "$1" ]] && source "$1" | ||
| return 0 |
There was a problem hiding this comment.
return
Returns the last exit code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to perform a local file and the file does not exist, ⚡ Zap will attempt a Git clone and error.
Modified to check to see if the directory containing the local file exists, if so, then treat as a local source only and not move on should the local file not exist.
For example when executing the below