Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: visually show if plugins need to be updated #131

Merged
merged 9 commits into from
May 2, 2023
Merged

Conversation

mamaraddio
Copy link
Member

image

@mamaraddio mamaraddio linked an issue Apr 24, 2023 that may be closed by this pull request
@wintermi
Copy link
Contributor

Visually this is great.

I do have a couple of comments:

Running a zap update with this change took longer than just running the update of all plugins.

In my opinion I think that this should become a new command/option, say zap update-check or zap update --check which could then allow for the zap update-all or zap update --all PR we received.

If the check was fast and you could not see each plugin being checked, I would say let's just do it.

Should we ask the discord channel which they would prefer?

During my tests no faster to execute, but visually less complex.
@mamaraddio
Copy link
Member Author

I think is more convenient to leave the two PRs, #123 and this, separated.

I've taken a look at #123 and I'll propose some changes to that.

I think zap have to continue to behave like now, the zap update command has to be "interactive" but it can accept an optional argument like zap update all or zap update supercharge and so on.

For what concern this PR, your commits make the codebase simpler but lose the "Local ahead remote" information that can look a bit stupid for the majority of the users, and actually nothing serious, but maybe who is participating to the development of a plugin could appreciate it. To avoid to call the same git command twice, it could be called once and stored in a variable.

I agree that we could submit this discussion on the Discord channel and to @ChristianChiarulli and leave the users chose what direction we should follow.

@mamaraddio
Copy link
Member Author

Last commit leads to the following by using git status -uno as suggested by @wintermi

Screenshot_2023-05-01-02-17-16-21_84d3000e3f4017145260f7618db1d683

@mamaraddio mamaraddio self-assigned this May 1, 2023
@mamaraddio mamaraddio added the enhancement New feature or request label May 1, 2023
mamaraddio and others added 2 commits May 2, 2023 02:12
* fix: resolve two issues with the Zap installation script (#133)

* feat: move the check to see if Zap is already installed to before any changes to the .zshrc file is made.
fix: change the launch of a new zsh session to rather reread the .zshrc file to maintain variables, history and allow the install script to be launched from an automation script.

* fix: change '.' to 'source'

* feat: cleanup updating all plugins output (#135)

---------

Co-authored-by: Matthew Winter <33818+wintermi@users.noreply.github.com>
fix `git remote update` output suppressed and language pinned to english for `git status -uno` to match `grep` regex
@wintermi wintermi merged commit cdb434a into master May 2, 2023
@wintermi wintermi deleted the mamaraddio branch May 2, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: check if plugin needs to be updated
2 participants