Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugins will be cleaned up after update, removed activate, deactivate, remove #61

Merged
merged 8 commits into from
Nov 13, 2022

Conversation

ChristianChiarulli
Copy link
Member

The regex to support activate and deactivate was getting a little complicated

deactivating a plugin can be done by commenting it out, activating by removing the comment

zap will ask the user after updating if they would like to remove plugins no longer in their config

@ChristianChiarulli
Copy link
Member Author

I could also be talked into making the cleaning operation it's own function that the user has to call explicitly

We could also allow it to be toggleable during the update process.

@Pheon-Dev
Copy link
Contributor

side quest, maybe you should

vim.cmd([[
    augroup zap_config
        autocmd!
        autocmd BufWritePost zap.zsh !shfmt -l -w .
    augroup END
]])

@Granddave
Copy link
Member

Check out pre-commit to not be able to commit a file that isn't formatted :)

@ChristianChiarulli ChristianChiarulli merged commit 95c9f79 into master Nov 13, 2022
@ChristianChiarulli ChristianChiarulli deleted the simplify branch November 13, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants